Optionally enable LLVM profile continuous mode #15166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM's profile instrumentation offers a continuous mode in which counters are continuously synced to a file rather than being dumped once in an exit hook. This is useful for coverage runs that include binaries that exit abnormally (e.g. in failure tests), but may require additional compiler flags and can negatively impact runtime performance and memory usage. Enabling continuous mode requires adding the "%c" modifier to the value of the LLVM_PROFILE_FILE environment variable. With this commit, the collect_coverage.sh script adds the modifier if the test environment has the variable LLVM_PROFILE_CONTINUOUS_MODE set. This allows both all and individual tests to use continuous mode by setting the variable, either via --test_env or the env attribute.
|
@c-mita This is a minimal change required to make LLVM profile's continuous mode usable with Bazel at all (everything else can be configured via existing knobs). Since I need this mode to properly generate complete coverage reports for Jazzer, I am very interested in getting at least this change into Bazel. If you would appreciate a better integration, I could submit a follow-up PR that adds the required compiler flags as toolchain features together with an experimental flag, similar to the existing |
meteorcloudy
added
team-Rules-CPP
|
@c-mita Sorry for the high PR load, but I assume this one is also yours to review |
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Apr 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report.
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Apr 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Apr 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
|
@c-mita Friendly ping |
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
May 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
May 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
May 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
May 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
May 20, 2022
Coverage reports can be generated via: bazel run //bazel/coverage Due to bazelbuild/bazel#15166, coverage collection does not yet encompass tests that end with a native sanitizer report. Temporarily updates .bazelversion to an unreleased version of Bazel that includes required coverage fixes.
|
@c-mita Friendly ping, could you take a look? |
c-mita
reviewed
Jun 9, 2022
There was a problem hiding this comment.
I think it's fine. @oquenchil - would it be worth getting this integrated with a flag?
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
This was referenced Jun 30, 2022
ckolli5
added a commit
that referenced
this pull request
Jun 30, 2022
LLVM's profile instrumentation offers a continuous mode in which counters are continuously synced to a file rather than being dumped once in an exit hook. This is useful for coverage runs that include binaries that exit abnormally (e.g. in failure tests), but may require additional compiler flags and can negatively impact runtime performance and memory usage. Enabling continuous mode requires adding the "%c" modifier to the value of the LLVM_PROFILE_FILE environment variable. With this commit, the collect_coverage.sh script adds the modifier if the test environment has the variable LLVM_PROFILE_CONTINUOUS_MODE set. This allows both all and individual tests to use continuous mode by setting the variable, either via --test_env or the env attribute. Closes #15166. PiperOrigin-RevId: 454558752 Change-Id: Id03d00d0644742e336feab41ea479d7d8527f6c4 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 2, 2022
LLVM's profile instrumentation offers a continuous mode in which counters are continuously synced to a file rather than being dumped once in an exit hook. This is useful for coverage runs that include binaries that exit abnormally (e.g. in failure tests), but may require additional compiler flags and can negatively impact runtime performance and memory usage. Enabling continuous mode requires adding the "%c" modifier to the value of the LLVM_PROFILE_FILE environment variable. With this commit, the collect_coverage.sh script adds the modifier if the test environment has the variable LLVM_PROFILE_CONTINUOUS_MODE set. This allows both all and individual tests to use continuous mode by setting the variable, either via --test_env or the env attribute. Closes bazelbuild#15166. PiperOrigin-RevId: 454558752 Change-Id: Id03d00d0644742e336feab41ea479d7d8527f6c4 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM's profile instrumentation offers a continuous mode in which
counters are continuously synced to a file rather than being dumped
once in an exit hook. This is useful for coverage runs that include
binaries that exit abnormally (e.g. in failure tests), but may require
additional compiler flags and can negatively impact runtime performance
and memory usage.
Enabling continuous mode requires adding the "%c" modifier to the value
of the LLVM_PROFILE_FILE environment variable. With this commit, the
collect_coverage.sh script adds the modifier if the test environment has
the variable LLVM_PROFILE_CONTINUOUS_MODE set. This allows both all and
individual tests to use continuous mode by setting the variable, either
via --test_env or the env attribute.